Linus Torvalds expressed frustration over the use of passive voice in merge commit messages, preferring active and imperative language instead.

He provided an example of how commit messages should be rewritten for clarity and consistency across the project.

Torvalds noted that while it’s not a major issue, it does add extra work when he has to rewrite messages to match his preference.

  • mox@lemmy.sdf.org
    link
    fedilink
    arrow-up
    110
    ·
    1 month ago

    I read his message. He didn’t seem grumpy or frustrated to me; just encouraging folks to use a certain style that’s already in wide use, for reduced noise and better consistency.

    • Otter@lemmy.ca
      link
      fedilink
      English
      arrow-up
      49
      ·
      edit-2
      1 month ago

      The message:

      "I try to make my merge commit messages be somewhat “cohesive”, and so I often edit the pull request language to match a more standard layout and language. It’s not a big deal, and often it’s literally just about whitespace so that we don’t have fifteen different indentation models and bullet syntaxes. I generally do it as I read through the text anyway, so it’s not like it makes extra work for me.

      But what does make extra work is when some maintainers use passive voice, and then I try to actively rewrite the explanation (or, admittedly, sometimes I just decide I don’t care quite enough about trying to make the messages sound the same).

      So I would ask maintainers to please use active voice, and preferably just imperative."

      Giving an example of a bad commit message, Torvalds provided this example: “In this pull request, the Xyzzy driver error handling was fixed to avoid a NULL pointer dereference.” He believes this should have been written as follows: “This fixes a NULL pointer dereference in …”

      • remotelove@lemmy.ca
        link
        fedilink
        arrow-up
        17
        ·
        1 month ago

        Any in many ways, that is the way engineers should speak to other engineers when analyzing a problem.

        If two or more people can actually share a common goal of finding the best solution, everyone involved should be making sure that no time is wasted chasing poor solutions. This not only takes the ability to be direct to someone else, but it also requires that you can parse what others are telling you.

        If someone makes something personal or takes something personal, they need a break. Go take a short walk or something. (Linus is a different sort of creature though. I get it.)

        TBH, this is part of the reason I chose my doctor (GP). She is extremely direct when problem solving and has no problems theory-crafting out loud. Sure, we are social to a degree, but we share many of the same professional mannerisms. (We had a short discussion on that topic the other day, actually. I just made her job easier because I give zero fucks about being judged for any of my personal health issues.)

  • katy ✨@lemmy.blahaj.zone
    link
    fedilink
    arrow-up
    14
    ·
    1 month ago

    depending on the time of day my commits range from war and peace to 'jfc here is just the message “yeah” for the next twenty commits because the client keeps requesting stupid ass decisions".

  • Skates@feddit.nl
    link
    fedilink
    arrow-up
    9
    ·
    1 month ago

    Linus Torvalds expressed frustration over the use of passive voice in merge commit messages, preferring active and imperative language instead.

    Things To Care About, vol 147, 2nd edition

  • Gallardo994@sh.itjust.works
    link
    fedilink
    arrow-up
    4
    ·
    1 month ago

    Upd

    Fix

    Upd

    Fuck

    Updated file1

    Fuck

    Fix

    Updated file2

    Merge remote-tracking branch other-user1-feature

    Fix after merge

    Upd

    Revert “Merge remote-tracking branch other-user1-feature”

    Revert “Revert “Merge remote-tracking branch other-user1-feature””

  • mindaika@lemmy.dbzer0.com
    link
    fedilink
    English
    arrow-up
    3
    ·
    1 month ago

    Updates & fixes -> I personally made updates with my bare hands and then also actively fixed some broken things also with my bare hands

    • ByteOnBikes@slrpnk.net
      link
      fedilink
      arrow-up
      1
      ·
      1 month ago

      Hey, I was wondering if you can update your commit with a punch in the face, if possible? No pressure thanks for contributing!

  • Reptorian@programming.dev
    link
    fedilink
    arrow-up
    1
    ·
    1 month ago

    When I do commit, I write up the title of what I did, and describe it, and then use periods for related commits. Just easier.

  • hector@sh.itjust.works
    link
    fedilink
    arrow-up
    4
    arrow-down
    7
    ·
    1 month ago

    Linus is a scary man and seems really hard to work with

    The fact that Linux blossomed anyways goes to show his talent

    • TrickDacy@lemmy.world
      link
      fedilink
      arrow-up
      15
      ·
      1 month ago

      People say things like this but he’s probably successfully worked with several hundred more people than your average worker ever will.

      • hector@sh.itjust.works
        link
        fedilink
        arrow-up
        10
        arrow-down
        1
        ·
        1 month ago

        He said he has trouble feeling empathy and he’s working on it. When this happens he was super mean towards the volunteer work of some contributors who quit the project.

        I’m not blaming Linus, I’m just saying I don’t feel like it’s a good atmosphere to work in Linux. It doesn’t feel friendly at all

        Thus the scary and stressing quality

        • MyNameIsRichard@lemmy.ml
          link
          fedilink
          arrow-up
          6
          arrow-down
          4
          ·
          1 month ago

          That’s not scary. The trick when dealing with that kind of review is to parse out the technical and not take the rest personally, which maybe takes a certain kind of personality.

          • derpgon@programming.dev
            link
            fedilink
            arrow-up
            3
            ·
            1 month ago

            I do that by default. I have to actively think about empathy when I do CRs, because the other devs (who should not be doing these kinds of mistakes) just can’t fucking do their job right for once.

            But when I am getting a review, I don’t get mad unless I am personally attacked (happened with a colleague who had a very high ego and somehow made it to a higher position, finally being let go about half a year back).

          • hector@sh.itjust.works
            link
            fedilink
            arrow-up
            4
            arrow-down
            1
            ·
            1 month ago

            Not being a jerk and having empathy are two necessary things to create a healthy work environment and are especially required when volunteers take from their off-time to work on your project.